Patch set 5:Code-Review +1
18 comments:
Patch Set #2, Line 9: Xeon-SP a Skylake Scalable Processor can have 36 CPU threads(18 cores). Current
*poke*
Done
nit: space before `(`
no `a`
Patch Set #5, Line 15: specifc
typo: specific
nit: SMI
Patch Set #5, Line 23: must is
`must` or `is`? Pick one of them, but not both 😄
nit: SMM
File Documentation/releases/coreboot-4.13-relnotes.md:
trailing whitespace
an extensive
number
I'd mention numbers here, e.g.: `more than 32 CPU threads`
trailing whitespace
Patch Set #5, Line 775: cpus = 1;
Instead of serializing relocation, could we use a smaller number instead?
int cpus = MIN(num_cpus, 24);
This changes the number of concurrent save states for the !X86_SMM_LOADER_VERSION2 case.
nit: CPUs
nit: CPUs
File src/cpu/x86/smm/smm_module_loaderv2.c:
Patch Set #2, Line 51: unsigned int
done
Done
Patch Set #2, Line 108: printk(BIOS_ERR, "%s: unable to get SMM module size\n", __func__);
No, we should not continue. Good catch. I've made the fix by adding a return 0 there.
Done
Patch Set #2, Line 112: 0xFFFF
Yes, this can be confusing. It means 64K segment. […]
Ack, thank you
Patch Set #2, Line 226: params->smm_main_entry_offset < stack_top) {
Done
Ack
To view, visit change 43684. To unsubscribe, or for help writing mail filters, visit settings.