Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42274 )
Change subject: mb/google/volteer/variants/terrador: Enable Cmd Mirror
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42274/7/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/terrador/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42274/7/src/mainboard/google/voltee...
PS7, Line 2: # BitMask where bits [3:0] are Controller 0 Channel [3:0] and
: # bits [7:4] are Controller 1 Channel [3:0].
+1. […]
Oops, I can read bitmasks 😄
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42274
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0db9fff0dddf35c99a6cb2a90d40886ed8e18686
Gerrit-Change-Number: 42274
Gerrit-PatchSet: 7
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 17 Jun 2020 20:44:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment