57 comments:
File src/soc/qualcomm/qcs405/clock.c:
code indent should use tabs where possible
please, no spaces at the start of a line
Patch Set #1, Line 67: .hz = 1000000,
code indent should use tabs where possible
Patch Set #1, Line 67: .hz = 1000000,
please, no spaces at the start of a line
Patch Set #1, Line 68: .hw_ctl = 0x0,
code indent should use tabs where possible
Patch Set #1, Line 68: .hw_ctl = 0x0,
please, no spaces at the start of a line
Patch Set #1, Line 69: .src = SRC_XO_19_2MHZ,
code indent should use tabs where possible
Patch Set #1, Line 69: .src = SRC_XO_19_2MHZ,
please, no spaces at the start of a line
Patch Set #1, Line 70: .div = DIV(48),
code indent should use tabs where possible
Patch Set #1, Line 70: .div = DIV(48),
please, no spaces at the start of a line
Patch Set #1, Line 71: //.m = 1,
code indent should use tabs where possible
Patch Set #1, Line 72: //.n = 2,
code indent should use tabs where possible
Patch Set #1, Line 73: //.d_2 = 4,
code indent should use tabs where possible
Patch Set #1, Line 73: //.d_2 = 4,
please, no space before tabs
Patch Set #1, Line 73: //.d_2 = 4,
please, no spaces at the start of a line
code indent should use tabs where possible
please, no space before tabs
please, no spaces at the start of a line
File src/soc/qualcomm/qcs405/spi.c:
void function return statements are not generally useful
Patch Set #1, Line 352: switch(slave->bus) {
switch and case should be at the same indent
Patch Set #1, Line 355: GPIO_PULL_DOWN, GPIO_6MA, GPIO_INPUT); //MISO - IN
code indent should use tabs where possible
Patch Set #1, Line 355: GPIO_PULL_DOWN, GPIO_6MA, GPIO_INPUT); //MISO - IN
please, no spaces at the start of a line
Patch Set #1, Line 356: gpio_configure(GPIO(38), 2,
code indent should use tabs where possible
Patch Set #1, Line 356: gpio_configure(GPIO(38), 2,
please, no spaces at the start of a line
Patch Set #1, Line 357: GPIO_PULL_DOWN, GPIO_6MA, GPIO_OUTPUT); //MOSI - Out
code indent should use tabs where possible
Patch Set #1, Line 357: GPIO_PULL_DOWN, GPIO_6MA, GPIO_OUTPUT); //MOSI - Out
please, no spaces at the start of a line
Patch Set #1, Line 358: gpio_configure(GPIO(117), 2,
code indent should use tabs where possible
Patch Set #1, Line 358: gpio_configure(GPIO(117), 2,
please, no spaces at the start of a line
Patch Set #1, Line 359: GPIO_NO_PULL, GPIO_6MA, GPIO_OUTPUT); //SCLK - out
code indent should use tabs where possible
Patch Set #1, Line 359: GPIO_NO_PULL, GPIO_6MA, GPIO_OUTPUT); //SCLK - out
please, no spaces at the start of a line
Patch Set #1, Line 360: gpio_configure(GPIO(118), 2,
code indent should use tabs where possible
Patch Set #1, Line 360: gpio_configure(GPIO(118), 2,
please, no spaces at the start of a line
Patch Set #1, Line 361: GPIO_PULL_DOWN, GPIO_6MA, GPIO_OUTPUT); //CS_0 - out
trailing whitespace
Patch Set #1, Line 361: GPIO_PULL_DOWN, GPIO_6MA, GPIO_OUTPUT); //CS_0 - out
code indent should use tabs where possible
Patch Set #1, Line 361: GPIO_PULL_DOWN, GPIO_6MA, GPIO_OUTPUT); //CS_0 - out
please, no spaces at the start of a line
Patch Set #1, Line 363: break;
trailing whitespace
Patch Set #1, Line 364: case 5:
code indent should use tabs where possible
Patch Set #1, Line 364: case 5:
please, no spaces at the start of a line
Patch Set #1, Line 366: gpio_configure(GPIO(26), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);
line over 80 characters
Patch Set #1, Line 366: gpio_configure(GPIO(26), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);
code indent should use tabs where possible
Patch Set #1, Line 366: gpio_configure(GPIO(26), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);
please, no spaces at the start of a line
Patch Set #1, Line 367: gpio_configure(GPIO(27), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);
line over 80 characters
Patch Set #1, Line 367: gpio_configure(GPIO(27), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);
code indent should use tabs where possible
Patch Set #1, Line 367: gpio_configure(GPIO(27), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);
please, no spaces at the start of a line
Patch Set #1, Line 368: gpio_configure(GPIO(28), 4, GPIO_PULL_UP, GPIO_16MA, GPIO_INPUT);
line over 80 characters
Patch Set #1, Line 368: gpio_configure(GPIO(28), 4, GPIO_PULL_UP, GPIO_16MA, GPIO_INPUT);
code indent should use tabs where possible
Patch Set #1, Line 368: gpio_configure(GPIO(28), 4, GPIO_PULL_UP, GPIO_16MA, GPIO_INPUT);
please, no spaces at the start of a line
Patch Set #1, Line 369: gpio_configure(GPIO(29), 4, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);
line over 80 characters
Patch Set #1, Line 369: gpio_configure(GPIO(29), 4, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);
code indent should use tabs where possible
Patch Set #1, Line 369: gpio_configure(GPIO(29), 4, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT);
please, no spaces at the start of a line
Patch Set #1, Line 524: printk(BIOS_ERR, "SPI FIFO read timeout \n");
unnecessary whitespace before a quoted newline
Patch Set #1, Line 529: }while(!(val & MAX_INPUT_DONE_FLAG));
space required after that close brace '}'
Patch Set #1, Line 529: }while(!(val & MAX_INPUT_DONE_FLAG));
space required before the open parenthesis '('
Patch Set #1, Line 651: printk(BIOS_ERR, "SPI FIFO write timeout \n");
unnecessary whitespace before a quoted newline
Patch Set #1, Line 656: }while(!(val & MAX_OUTPUT_DONE_FLAG));
space required after that close brace '}'
Patch Set #1, Line 656: }while(!(val & MAX_OUTPUT_DONE_FLAG));
space required before the open parenthesis '('
Patch Set #1, Line 678: printk(BIOS_ERR, "SPI:DBG write not success \n");
unnecessary whitespace before a quoted newline
To view, visit change 31142. To unsubscribe, or for help writing mail filters, visit settings.