3 comments:
File src/mainboard/pcengines/apu2/gpio_ftns.c:
Patch Set #8, Line 41: /* out the data value to prevent glitches */
If the IOMUX was already programmed for GPIO, this would need to copy GPIO_PIN_STS to GPIO_OUTPUT_VA […]
the code you removed here might cause glitches and doesn't do what the comment says. i don't think that copying the pin input value to the output register before switching to output mode should be the way to go here; either set all bits in one atomic operation or set the output value first and then the direction to output to avoid output glitches
Patch Set #8, Line 50: iomux_write8(gpio, iomux_ftn & 0x3);
Does GPIO_PIN_STS follow the pad state/voltage even before IOMUX is set to GPIO function?
good question. see my comment above on why it shouldn't matter
File src/mainboard/pcengines/apu2/romstage.c:
Patch Set #8, Line 43: gpio_output(gpio, 0);
Left more unresolved comments about this sequence.
this isn't needed any more after my common gpio patches. See CB:49119
To view, visit change 42521. To unsubscribe, or for help writing mail filters, visit settings.