9 comments:
Patch Set #24, Line 10: - graphics
I would capitalize each element, as well as the acronyms: […]
Done
nit: I would omit the "etc"
Done
Patch Set #24, Line 18: These are the initial settings for JSL
super-nit: Period at the end.
Done
Patch Set #24, Line 24: jasper lake
Or, if this Jasper Lake board is google/dedede, maybe use: […]
Done
File src/soc/intel/tigerlake/chip.h:
Patch Set #24, Line 208: enum {
Is this is a bitfield? If so, I would use shifts. […]
Agree. Done.
File src/soc/intel/tigerlake/fsp_params_jsl.c:
Shouldn't this mirror the value above?
want to explicitly set it for S3 flow.
File src/soc/intel/tigerlake/romstage/fsp_params_jsl.c:
Patch Set #24, Line 32: disable
disable*d*
Done
PCI
Done
VT-d
Done
To view, visit change 38461. To unsubscribe, or for help writing mail filters, visit settings.