Attention is currently required from: Kyösti Mälkki, Sergii Dmytruk.
View Change
1 comment:
Patchset:
Patch Set #3:
Does this force all arithmetic involving KiB to use 64bit arithmetic? For i386 builds too?
Not all, only those that would eventually end up in 64bit variable. Compilers are allowed to use smaller width if it doesn't change the result, and even skip multiplication entirely or change the multiplier if it can be calculated at the time of compilation.
Nevertheless, result of multiplication on i386 is returned in `%edx:%eax`, so it already is 64bit wide.
To view, visit change 70106. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie60a6ee82db80328e44639175272cc8097f36c3b
Gerrit-Change-Number: 70106
Gerrit-PatchSet: 3
Gerrit-Owner: Krystian Hebel <krystian.hebel@3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Mon, 05 Dec 2022 14:19:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-MessageType: comment