Attention is currently required from: Jonathan Zhang, Paul Menzel, David Hendricks, Rocky Phagura, Arthur Heymans, Aaron Durbin.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52518 )
Change subject: src/cpu/x86/smm: remove debug message; not thread safe
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52518/comment/adf20847_982decef
PS2, Line 9: the console init
If you word it like that, it sounds like you're removing *the* SMM console
init. But this is merely about an odd error path.
How about
This patch removes a console_init() call and a debug...
?
https://review.coreboot.org/c/coreboot/+/52518/comment/0944bfce_8887cb22
PS2, Line 10: This prevents system hangs (soft hangs)
: while in SMM if user drops in a new SOC with more cores or another
: socket.
Shouldn't CONFIG_MAX_CPUS account for that?
https://review.coreboot.org/c/coreboot/+/52518/comment/5ab87c58_3f1eb85e
PS2, Line 15: Tested on DeltaLake mainboard with SMM enabled and 52 CPU threads. .
With a low MAX_CPUS setting?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52518
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e8af35d1cde78b327144b6a9da528ae7870e874
Gerrit-Change-Number: 52518
Gerrit-PatchSet: 2
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Rocky Phagura
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 23 Apr 2021 11:01:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment