Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.

Felix Held has uploaded this change for review.

View Change

soc/amd/sabrina/include/amd_pci_int_defs.h: remove PIRQ_SATA

Sabrina has no SATA controller, so remove the corresponding PIRQ
mapping. This was verified with PPR #57243 Rev 1.53.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I98ffa3675c361e8a74c50ebfc37e79ae63dacc85
---
M src/soc/amd/sabrina/include/soc/amd_pci_int_defs.h
1 file changed, 1 insertion(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/61601/1
diff --git a/src/soc/amd/sabrina/include/soc/amd_pci_int_defs.h b/src/soc/amd/sabrina/include/soc/amd_pci_int_defs.h
index a3f8b82..424b224 100644
--- a/src/soc/amd/sabrina/include/soc/amd_pci_int_defs.h
+++ b/src/soc/amd/sabrina/include/soc/amd_pci_int_defs.h
@@ -1,7 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-/* TODO: Check if this is still correct */
-
#ifndef AMD_SABRINA_AMD_PCI_INT_DEFS_H
#define AMD_SABRINA_AMD_PCI_INT_DEFS_H

@@ -40,9 +38,7 @@
#define PIRQ_GPIOA 0x21 /* GPIOa from PAD_FANIN0 */
#define PIRQ_GPIOB 0x22 /* GPIOb from PAD_FANOUT0 */
#define PIRQ_GPIOC 0x23 /* GPIOc no IRQ connected */
-/* 0x24-0x40 reserved */
-#define PIRQ_SATA 0x41 /* SATA */
-/* 0x42 reserved */
+/* 0x24-0x42 reserved */
#define PIRQ_EMMC 0x43 /* eMMC */
/* 0x44-0x4f reserved */
#define PIRQ_GPP0 0x50 /* GPPInt0 */

To view, visit change 61601. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98ffa3675c361e8a74c50ebfc37e79ae63dacc85
Gerrit-Change-Number: 61601
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Attention: Raul Rangel <rrangel@chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-MessageType: newchange