Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.

Felix Held uploaded patch set #4 to the change originally created by Kyösti Mälkki.

View Change

soc/amd: remove special GPIO_2 override soc_gpio_hook

This override was added to have the SCI mapping configured if GPIO was
used as WAKE_L pin. This however didn't set up the SCI level and trigger
information, so it likely never worked as intended. The soc_gpio_hook is
kept for Cezanne, since this SoC needs some GPIO hooks to enable/disable
some functionality that somehow doesn't get controlled by the GPIO mux,
so when you switch certain pins into GPIO mode, the special
functionality doesn't get disabled automatically and additional
registers have to be written to behave as intended.

Change-Id: I44661f05c8f517ece88714c625603579731d174b
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
---
M src/soc/amd/cezanne/gpio.c
M src/soc/amd/picasso/gpio.c
M src/soc/amd/stoneyridge/gpio.c
3 files changed, 0 insertions(+), 17 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/43049/4

To view, visit change 43049. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44661f05c8f517ece88714c625603579731d174b
Gerrit-Change-Number: 43049
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: newpatchset