Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Felix Held: Looks good to me, approved
soc/amd/picasso: Remove call to setup_bsp_ramtop

We don't use amd_setup_mtrrs, bsp_topmem or bsp_topmem2 in picasso.

BUG=b:147042464
TEST=Boot to OS on trembyle

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I1941934975dfea4f189347811b003a33996c887a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42086
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
---
M src/soc/amd/picasso/chip.c
1 file changed, 0 insertions(+), 2 deletions(-)

diff --git a/src/soc/amd/picasso/chip.c b/src/soc/amd/picasso/chip.c
index ed39b53..d364b9a 100644
--- a/src/soc/amd/picasso/chip.c
+++ b/src/soc/amd/picasso/chip.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <cpu/amd/mtrr.h>
#include <console/console.h>
#include <device/device.h>
#include <device/pci.h>
@@ -159,7 +158,6 @@

data_fabric_set_mmio_np();
southbridge_init(chip_info);
- setup_bsp_ramtop();
}

static void soc_final(void *chip_info)

To view, visit change 42086. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1941934975dfea4f189347811b003a33996c887a
Gerrit-Change-Number: 42086
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Marshall Dawson <marshall@marshalldawson.com>
Gerrit-MessageType: merged