[coreboot-gerrit] [M] Change in coreboot[main]: security/tpm: Retrieve factory configuration for device w/ Google TPM

[Paul Menzel (Code Review)]

Attention is currently required from: Christian Walter, Nick Vaccaro, Paz Zcharya, Shelley Chen, Subrata Banik, Tim Van Patten.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79736?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: security/tpm: Retrieve factory configuration for device w/ Google TPM
......................................................................

Patch Set 4: Code-Review+1

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/79736/comment/66f7a253_a553eefb :
PS4, Line 9: factory configuration data
This is currently encoded in 8 bits?

File src/security/tpm/tss/vendor/cr50/cr50.c:

https://review.coreboot.org/c/coreboot/+/79736/comment/ce8c437b_c12d1afc :
PS4, Line 186: 	printk(BIOS_INFO, "Reading factory config\n");
Should the result be printed at the end?