Felix Held submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
soc/nvidia/tegra210: Fix flushing SPI fifo

This will avoid clearing the other bits in fifo_status.

Change-Id: I7917b3f8d9af6056ed872b7e48cef9c3deba5119
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70137
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
---
M src/soc/nvidia/tegra210/spi.c
1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/src/soc/nvidia/tegra210/spi.c b/src/soc/nvidia/tegra210/spi.c
index 0f38df2..e6f667a 100644
--- a/src/soc/nvidia/tegra210/spi.c
+++ b/src/soc/nvidia/tegra210/spi.c
@@ -331,7 +331,7 @@

uint32_t fifo_status = read32(&spi->regs->fifo_status);
fifo_status |= flush_mask;
- write32(&spi->regs->fifo_status, flush_mask);
+ write32(&spi->regs->fifo_status, fifo_status);

while (read32(&spi->regs->fifo_status) & flush_mask)
;

To view, visit change 70137. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7917b3f8d9af6056ed872b7e48cef9c3deba5119
Gerrit-Change-Number: 70137
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged