View Change

1 comment:

• File src/commonlib/bsd/include/commonlib/bsd/cbfs_private.h:

  • Patch Set #11, Line 4: PRIVATE

    Sounds good, added comment. (Note that CB:39327 also adds src/include/cbfs_private.h for the coreboot-specific parts of the "unsafe" API. I think I'll need direct access to some of that for program loading so I can't have it all local in lib/cbfs.c. I also have a warning comment there, I may flesh it out a bit more once I have all the use cases implemented and a better idea what APIs need to be exposed for what.)

    I agree with Angel that this should also have a page in Documentation/ later, but since I don't have all the answers yet I'd say I'll finish writing the code first, and then document it later when all the design decisions are final.

    I read this and just thought of something: how about writing the documentation first, and use it to discuss the design decisions? It might be less work than to redesign the code later should any of the decisions not be accepted (which I expect to be unlikely, but not impossible).

To view, visit change 38421. To unsubscribe, or for help writing mail filters, visit settings.