Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32142 )
Change subject: ec/google/chromeec: Remove redundant use of ACPI offset operator ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32142/2/src/ec/google/chromeec/acpi/ec.asl File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/#/c/32142/2/src/ec/google/chromeec/acpi/ec.asl@a... PS2, Line 90:
Looking back at this, it seems like this was done to ensure that we don't overrun the device feature […]
It's unfortunate that the iasl devs now consider redundant Offsets worthy of a warning or error. I wonder if we should push for some kind of location assert to make the distinction explicit?