Attention is currently required from: Christian Walter, Felix Singer.
View Change
3 comments:
Commit Message:
Patch Set #1, Line 6:
> `A patch subject line should describe the change not the tool that found it` […]
Thanks for your review. I was following what was documented in the tutorial:
https://doc.coreboot.org/tutorial/part2.html#step-4a-use-the-command-line-to-stage-and-submit-a-commit
Made the change you suggested.
Patch Set #1, Line 7: src/
We don't add src when we do changes to files from there. Remove.
Thanks for your review. Done.
Patchset:
To view, visit change 82001. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 1
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Attention: Christian Walter <christian.walter@9elements.com>
Gerrit-Comment-Date: Fri, 19 Apr 2024 23:24:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-MessageType: comment