Attention is currently required from: Jérémy Compostella.

Felix Held has uploaded this change for review.

View Change

[WIP] arch/x86/include/mpspec: add comment to mpc_config_ioapic

The size of void * depends on whether coreboot is built for 32 or 64 bit
mode, so this smells like a possible bug to me.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I8ecd924b53cc8ea9505e13808ca53b04c3334965
---
M src/arch/x86/include/arch/smp/mpspec.h
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/80359/1

diff --git a/src/arch/x86/include/arch/smp/mpspec.h b/src/arch/x86/include/arch/smp/mpspec.h
index 80ae7e8..31213f2 100644
--- a/src/arch/x86/include/arch/smp/mpspec.h
+++ b/src/arch/x86/include/arch/smp/mpspec.h
@@ -102,7 +102,7 @@
 	u8 mpc_apicver;
 	u8 mpc_flags;
 #define MPC_APIC_USABLE		0x01
-	void *mpc_apicaddr;
+	void *mpc_apicaddr;//32 vs 64 bit?!
 } __packed;
 
 struct mpc_config_intsrc {

To view, visit change 80359. To unsubscribe, or for help writing mail filters, visit settings.