oh, wait - there's already common/dsi.c. dsi_v2 is not a good name in that case. Do you have some other names or identifiers to help people understanding "this is the dsi implementation for 8183 and 8192, but not 8173"?

View Change

To view, visit change 48530. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I722d3e67f230ab8eb729900cdf15b922eb91a072
Gerrit-Change-Number: 48530
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin <yidi.lin@mediatek.com>
Gerrit-Reviewer: Huijuan Xie <huijuan.xie@mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 10 Dec 2020 14:12:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment