Patch Set 5:

I'm not sure if removing an unused header is better than risking indirect inclusion later on (people start using the uint* types and they only work because another header pulled them in)

in this changes, there is no file uses a <types.h> , stdint, stddef, stdbool or commonlib/bsd/cb_err.h or commonlib/helpers.h
not a single macro or function!

(please see also https://review.coreboot.org/c/coreboot/+/41817 )


View Change

To view, visit change 41677. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d99d844cc58d80acb505d98da9d3ec76319b2eb
Gerrit-Change-Number: 41677
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: David Guckian <david.guckian@intel.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 30 May 2020 15:03:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment