Attention is currently required from: Jeff Daly, Paul Menzel, Stefan Reinauer, Angel Pons.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60737 )
Change subject: util/ifdtool: Add support for Denverton platforms
......................................................................
Patch Set 3:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/60737/comment/b479a0d2_95026f2a
PS3, Line 717: has_10gbe_A = (platform == PLATFORM_DNV);
: has_10gbe_B = (platform == PLATFORM_DNV);
Is it necessary to use two equivalent variables?
Well this was my suggestion, I don't know if there is platform that could only have A or B. There is a printf() per region, I think it is cleaner done like this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60737
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie85b071201fb3f88e2c780cfb8d6a52629aa0ced
Gerrit-Change-Number: 60737
Gerrit-PatchSet: 3
Gerrit-Owner: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 13:57:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment