Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49058 )
Change subject: mb/google/hatch (baseboard): add ACPI backlight support ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/49058/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49058/1//COMMIT_MSG@10 PS1, Line 10: PUFF-based variants do not have an attached display Um, this sounds like you're saying PUFF-based variants are headless. AFAIK, HATCH variants are Chromebooks, and PUFF variants are Chromeboxes. If this is correct, I would reword this as follows:
PUFF-based variants are Chromeboxes, which do not have an integrated panel. Thus, they don't need to be adapted.
(I'm going to ask some Google people if I can split HATCH and PUFF, for sanity's sake)