1 comment:
File src/drivers/usb/pci_xhci/pci_xhci.c:
Sorry about the delay in review here. I was giving this some thought. […]
1. I didn't want to maintain another list of PCI_IDs. When any other SoC wants to use this driver, it requires then to touch this file which I think is unnecessary. This driver uses standard xHCI registers so it should support any xHCI controller. I guess that's the standard practice though.
2. Ok
3. I'm fine with that, just though it removed some of the magic and made it clearer to have it in the device tree.
4. If we add soc_get_controller_wake_gpe I think it should be in a more common location. I don't think that this driver should implement the weak method since this is pci_xhci and not soc code. I'm just not sure where to place it... Do you have a suggestion?
Another option to remove the chip from device tree: We could have the picasso/chip.c:enable_dev manually set the chip for the PCI device. Additionally it could construct the `chip_info`. We could have it call a `mainboard_get_device_gpe()` method to get the GPE. Though this seems like a lot of magic too...
Thoughts?
To view, visit change 41900. To unsubscribe, or for help writing mail filters, visit settings.