21 comments:
This should be at the end of the commit message
Done.
Patch Set #31, Line 28: Seabios
SeaBIOS
Done.
Why are there two Change-Id lines?
Done.
File Documentation/mainboard/asus/a88xm-e.md:
Patch Set #31, Line 29: 8603E
IT8603E
Done.
Trailing space on all lines, is it on purpose?
Done.
Patch Set #31, Line 87: can broke
`can break` ?
Done.
Patch Set #31, Line 98: Kaveri
Kaveri uses BinaryPI, AFAIK
for Balazs to address
File src/mainboard/asus/a88xm-e/Kconfig:
DDR3
Done.
DDR3
Done.
DDR3
Done.
config ONBOARD_VGA_IS_PRIMARY
bool
default y
Why?
question for Balazs
config CONFIG_DRIVERS_PS2_KEYBOARD
bool
default y
Why?
question for Balazs
config POST_IO
bool
default n
config CONFIG_POST_DEVICE_PCI_PCIE
bool
default y
Why?
question for Balazs
config DEVICETREE
string
default "devicetree.cb"
This should be the default already
Done.
File src/mainboard/asus/a88xm-e/buildOpts.c:
Patch Set #31, Line 145: FALSE
Seems to be misaligned
Done.
File src/mainboard/asus/a88xm-e/cmos.layout:
Patch Set #31, Line 32: 456 1 e 1 ECC_memory
Isn't ECC disabled in BuildOpts. […]
Mistake borrowed from F2A85-M. Need to understand a format of this table to fix, will do a bit later...
Patch Set #31, Line 47: 6 5 Notice
There are some missing debug levels
Mistake borrowed from F2A85-M. Need to understand a format of this table to fix, will do a bit later...
File src/mainboard/asus/a88xm-e/mainboard.c:
Patch Set #31, Line 22: thatcher board
Um, but this isn't Thatcher?
Done.
File src/mainboard/asus/a88xm-e/mptable.c:
Put a comma after this, for consistency
Done.
I would use `84` instead
Done.
Same
Done.
To view, visit change 30987. To unsubscribe, or for help writing mail filters, visit settings.