View Change
1 comment:
Commit Message:
Patch Set #2, Line 15: access
Great plan. […]
Something that would be good to know is whether Bus Master needs to be enabled *while* initializing the device. AFAIK, the only device for which BWGs explicitly state that Bus Master needs to be set during initialization is the iGPU.
If we don't need to enable Bus Master at all until we're ready to jump to the payload, we can postpone setting it as much as possible to mitigate DMA attacks
To view, visit change 44512. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife65f6029d2f966e321f616e85f59f4c37c42145
Gerrit-Change-Number: 44512
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Subrata Banik <subi.banik@gmail.com>
Gerrit-Comment-Date: Wed, 09 Sep 2020 09:58:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subi.banik@gmail.com>
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com>
Comment-In-Reply-To: Subrata Banik <subrata.banik@intel.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment