5 comments:
File src/soc/mediatek/mt8192/Makefile.inc:
Patch Set #14, Line 12: bootblock
Do we really need to enable PMIF in bootblock? Can we do that in romstage?
I think there are several modules, like rtc/clkbuf/srclken_rc, which depend on pmif module. It is OK for me to move pmif module in romstage if these modules can move, too.
File src/soc/mediatek/mt8192/include/soc/pmif.h:
Patch Set #7, Line 134: unsigned int
the address and value of pmic mt6359p is 32 bit, so I think u32 should be enough.
Done
File src/soc/mediatek/mt8192/pmif_clk.c:
Please explain why 50 is needed, or add a reference to which chapter this defined in which datasheet […]
We need the delay for stable clk, and it is described in ULPOSC_SW_Calibration.doc.
File src/soc/mediatek/mt8192/pmif_spi.c:
In that pattern documented somewhere?
No. This part is to do the calibration to find out the correct timing of spi.
The test pattern is to verify the bit 0~15 of the read-back data.
0x6996 = 2'b[0110100110010110]
0x9669 = 2'b[1001011001101001]
File src/soc/mediatek/mt8192/pmif_spi.c:
add a reference for where we can find this 100 being defined.
After checking, the project don't use modem feature, so we remove it.
To view, visit change 45398. To unsubscribe, or for help writing mail filters, visit settings.