View Change

9 comments:

• File src/ec/hp/it8987e/ec.h:

  • Patch Set #1, Line 25: #define EC_IO_HIGH EC_IO + 1

    Macros with complex values should be enclosed in parentheses

  • Patch Set #1, Line 26: #define EC_IO_LOW EC_IO + 2

    Macros with complex values should be enclosed in parentheses

  • Patch Set #1, Line 27: #define EC_IO_DATA EC_IO + 3

    Macros with complex values should be enclosed in parentheses

• File src/ec/hp/it8987e/ec.c:

  • Patch Set #1, Line 74: if (!output_buffer_full(KBD_STATUS)) return 0;

    trailing statements should be on next line

  • Patch Set #1, Line 80: if (!input_buffer_empty(KBD_STATUS)) return;

    trailing statements should be on next line

  • Patch Set #1, Line 86: if (!input_buffer_empty(KBD_STATUS)) return;

    trailing statements should be on next line

  • Patch Set #1, Line 97: if (!output_buffer_full(EC_SC)) return 0;

    trailing statements should be on next line

  • Patch Set #1, Line 103: if (!input_buffer_empty(EC_SC)) return;

    trailing statements should be on next line

  • Patch Set #1, Line 109: if (!input_buffer_empty(EC_SC)) return;

    trailing statements should be on next line

To view, visit change 34984. To unsubscribe, or for help writing mail filters, visit settings.