View Change

5 comments:

• File payloads/libpayload/README:

  • Patch Set #6, Line 28: you might have to install the 32bit libgcc version, otherwise

    This doesn't really make sense, the issue this is talking about is x86 specific. […]

    Thank you for your comment. I will apply your comment in the next update.

• File payloads/libpayload/bin/lpgcc:

  • Patch Set #6, Line 203: $DEFAULT_CC $_LDFLAGS $HEAD_O $CMDLINE $_CFLAGS -lpayload $_LIBGCC -lc

    Why do you need -lc?

    This was my mistake. I didn't notice that 'libpayload.a' already has 'libc.a'.
    I will revert this change in next update. Thank you for your comment!

• File payloads/libpayload/drivers/Makefile.inc:

  • Patch Set #6, Line 53:

    Why are you removing the ifneq?

    I removed it because 'libc/time.c', which is included as a default, uses timer_hz() and timer_raw_value() but the implementations of these are not included as a default. So I thought a timer is necessary to build.

    However, I understood this change doesn't make sense. So I will revert it in next update.

    Is it ok just to set up CONFIG_LP_TIMER_GENERIC_HZ to 1M or some value above it in order to avoid build errors?

• File payloads/libpayload/include/arm/arch/io.h:

  • Patch Set #6, Line 37: a

    ARM doesn't support in/out. […]

    Do you mean ARM only supports memory mapped I/O?

• File payloads/libpayload/sample/Makefile:

  • Patch Set #6, Line 35:

    POWERPC support has been removed a long time ago so I believe this is correct.

    Thank you for your comment, Julius.

    Currently, libpayload only has ARM, X86, ARM64, and MIPS as a target architecture. Also, the variable name of x86 changed from i386 to x86_32. It is defined at .xcompile.

To view, visit change 33287. To unsubscribe, or for help writing mail filters, visit settings.