3 comments:
Patch Set #5, Line 9: This adds common code to handle SMM save states based on the SMM
it's not clear why runtime detection is done here
File src/cpu/x86/smm/smm_save_state.c:
Patch Set #5, Line 27: uint8_t *top = smm_get_save_state_top(0);
is it guaranteed that all CPUs have entered SMM and stored their save state?
Is this code only called on CPU 0?
Patch Set #5, Line 251: uint32_t smm_revision = smm_get_revision();
isn't that known at compile-time?
That would allow to link only the savestate ops that's needed on the current CPU
To view, visit change 36661. To unsubscribe, or for help writing mail filters, visit settings.