Patch Set 1:

Three scenarios to consider:

a) INSTALL_SMM=y, HAVE_SMI_HANDLER=y

Current (unfortunate) situation. Build and install smm -class. Let MP init raise SMIs and do its job.

b) INSTALL_SMM=n, HAVE_SMI_HANDLER=y

Don't build smm -class.
Absolute minimal resident SMM may be installed, like asm inline "rsm"?
Let MP init raise SMIs to relocate SMM stacks?
On entry to payload, SMRAM can be locked or left unlocked.

Is this behavior a long term goal?

What definition do we have HAVE_SMI_HANDLER to be going forward? That it can support SMM? And we want to turn off the permanent handler installation with INSTALL_SMM?

I think the combinations seem legit, but I think the naming could be more descriptive in what we're aiming for.


c) INSTALL_SMM=n, HAVE_SMI_HANDLER=n

Not possible for MP init to raise SMIs.
See CB:34152 and CB:34158 what is required on source level.
Little benefits in comparison to b) above?

View Change

1 comment:

To view, visit change 34257. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe827193527b7e16a3360b92bc0be25ceec8d1e6
Gerrit-Change-Number: 34257
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 15 Jul 2019 15:06:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment