Jeremy Soller uploaded patch set #3 to this change.

View Change

pciexp: Add support for allocating PCI express hotplug resources

This change adds support for allocating resources for PCI express hotplug
bridges when PCIEXP_HOTPLUG is selected. By default, this will add 32 PCI
subordinate numbers (buses), 256 MiB of prefetchable memory, 8 MiB of
non-prefetchable memory, and 8 KiB of I/O space to any device with the
PCI_EXP_SLTCAP_HPC bit set in the PCI_EXP_SLTCAP register, which
indicates hot-plugging capability. The resource allocation is configurable,
please see the PCIEXP_HOTPLUG_* variables in src/device/Kconfig.

In order to support the allocation of hotplugged PCI buses, a new field
is added to struct device called hotplug_buses. This is defaulted to
zero, but when set, it adds the hotplug_buses value to the subordinate
value of the PCI bridge. This allows devices to be plugged in and
unplugged after boot.

This code was tested on the System76 Darter Pro (darp6). Before this
change, there are not enough resources allocated to the Thunderbolt
PCI bridge to allow plugging in new devices after boot. This can be
worked around in the Linux kernel by passing a boot param such as:

This change makes it possible to use Thunderbolt hotplugging without
kernel parameters, and attempts to match closely what our motherboard
manufacturer's firmware does by default.

Signed-off-by: Jeremy Soller <>
Change-Id: I500191626584b83e6a8ae38417fd324b5e803afc
M src/device/Kconfig
M src/device/pci_device.c
M src/device/pciexp_device.c
M src/include/device/device.h
M src/include/device/pci_def.h
M src/include/device/pciexp.h
6 files changed, 120 insertions(+), 1 deletion(-)

git pull ssh:// refs/changes/46/35946/3

To view, visit change 35946. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I500191626584b83e6a8ae38417fd324b5e803afc
Gerrit-Change-Number: 35946
Gerrit-PatchSet: 3
Gerrit-Owner: Jeremy Soller <>
Gerrit-Reviewer: Jeremy Soller <>
Gerrit-Reviewer: Martin Roth <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Aaron Durbin <>
Gerrit-CC: Brandon Breitenstein <>
Gerrit-CC: Divya S Sasidharan <>
Gerrit-CC: Duncan Laurie <>
Gerrit-CC: Felix Held <>
Gerrit-CC: Furquan Shaikh <>
Gerrit-CC: Kyösti Mälkki <>
Gerrit-CC: Matt DeVillier <>
Gerrit-CC: Mimoja <>
Gerrit-CC: Nathaniel L Desimone <>
Gerrit-CC: Nico Huber <>
Gerrit-CC: Patrick Rudolph <>
Gerrit-CC: Paul Menzel <>
Gerrit-CC: Subrata Banik <>
Gerrit-MessageType: newpatchset