2 comments:
File src/ec/google/chromeec/ec.h:
Patch Set #2, Line 309: int *num_ports
Just curious: Is this input parameter strictly required? Can we return -1 on error and # of ports otherwise. Or do you want to take in input parameter for consistency with other EC functions here?
enum ec_pd_power_role_caps *power_role_cap,
enum ec_pd_try_power_role_caps *try_power_role_cap,
enum ec_pd_data_role_caps *data_role_cap,
enum ec_pd_port_location *port_location
Should these be put in a structure so that in the future if there are more things that need to be returned they can just be added to the structure without having to change each call site?
To view, visit change 38540. To unsubscribe, or for help writing mail filters, visit settings.