[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add required FSP UPD changes for CML

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31284 )

Change subject: soc/intel/cannonlake: Add required FSP UPD changes for CML
......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/#/c/31284/10/src/soc/intel/cannonlake/chip.h 
File src/soc/intel/cannonlake/chip.h:

https://review.coreboot.org/#/c/31284/10/src/soc/intel/cannonlake/chip.h@295 
PS10, Line 295: #if IS_ENABLED(CONFIG_SOC_INTEL_COMETLAKE)
              : 	/*
              : 	 * SerialIO device mode selection:
              : 	 * PchSerialIoDisabled,
              : 	 * PchSerialIoPci,
              : 	 * PchSerialIoHidden,
              : 	 * PchSerialIoLegacyUart,
              : 	 * PchSerialIoSkipInit
              : 	 */
              : 	uint8_t SerialIoI2cMode[CONFIG_SOC_INTEL_I2C_DEV_MAX];
              : 	uint8_t SerialIoGSpiMode[CONFIG_SOC_INTEL_COMMON_BLOCK_GSPI_MAX];
              : 	uint8_t SerialIoUartMode[SOC_INTEL_CML_UART_DEV_MAX];
              : #else
> Do we really need this? Can't we just have the same SerialIoDevMode[] and then handle it correctly w […]

we can do that i believe so that we can use old config structure as below.