[coreboot-gerrit] Change in coreboot[master]: soc/intel/alderlake: set power limits dynamically for thermal

[EricR Lai (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Sumeet R Pawnikar, Patrick Rudolph, Karthik Ramasubramanian.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57035 )

Change subject: soc/intel/alderlake: set power limits dynamically for thermal
......................................................................


Patch Set 8: Code-Review+1

(2 comments)

Patchset:

PS8: 
Others LGTM.


File src/soc/intel/alderlake/systemagent.c:

https://review.coreboot.org/c/coreboot/+/57035/comment/9415a933_3763ac82 
PS8, Line 74: 	sa_pci_id = sa ? pci_read_config16(sa, PCI_DEVICE_ID) : 0xFFFF;
if sa_pci_id == 0xFFFF should we halt? or assert some error?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57035
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic331a3debb076ef08a312a31edc1468974fd4902
Gerrit-Change-Number: 57035
Gerrit-PatchSet: 8
Gerrit-Owner: Sumeet R Pawnikar <[e-mail]>
Gerrit-Reviewer: EricR Lai <[e-mail]>
Gerrit-Reviewer: Furquan Shaikh <[e-mail]>
Gerrit-Reviewer: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Furquan Shaikh <[e-mail]>
Gerrit-Attention: Tim Wawrzynczak <[e-mail]>
Gerrit-Attention: Sumeet R Pawnikar <[e-mail]>
Gerrit-Attention: Patrick Rudolph <[e-mail]>
Gerrit-Attention: Karthik Ramasubramanian <[e-mail]>
Gerrit-Comment-Date: Wed, 01 Sep 2021 13:45:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment