Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39925 ) Change subject: boot_device: Add boot_device_lockdown ...................................................................... Patch Set 6: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/39925/6/src/southbridge/intel/commo... File src/southbridge/intel/common/finalize.c: https://review.coreboot.org/c/coreboot/+/39925/6/src/southbridge/intel/commo... PS6, Line 30: /* Lock SPIBAR */ : RCBA32_OR(0x3804, (1 << 15)); This removes the option to lock SPIBAR via SMM. Not sure if anyone cares to do it that way anymore... -- To view, visit https://review.coreboot.org/c/coreboot/+/39925 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d3a80a2e278c77212e1fba5236ea639ea018837 Gerrit-Change-Number: 39925 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 20 Apr 2020 13:05:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment