9 comments:
File src/drivers/aspeed/common/ast_i2c.c:
Patch Set #6, Line 30: * Authors: Dave Airlie <airlied@redhat.com>
why not just put these two lines below the copyright above?
Done
*/
#include
nit: newline before include
Done
File src/drivers/aspeed/common/ast_mode_corebootfb.c:
*/
/*
* Authors: Dave Airlie <airlied@redhat.com>
* Authors: 9Elements Agency GmbH <patrick.rudolph@9elements.com>
move below Copyright?
Done
newline
Done
Patch Set #6, Line 40: expexts
expects
Done
Patch Set #6, Line 51: dev_err(dev->pdev, "BAR0 resource not found.\n");
eh, just wasted a lot of time to figure out why this line compiles... […]
Done
Patch Set #6, Line 81: mode->crtc_hblank_start = edid->mode.ha + edid->mode.hso;
Update: drm_display_mode.*display seems to include the borders, so they […]
Done
Patch Set #6, Line 82: mode->crtc_hblank_end = edid->mode.ha + edid->mode.hso + edid->mode.hbl;
This should be just active + blank?
Done
Patch Set #6, Line 85: mode->crtc_htotal = MAX(mode->crtc_hblank_end, mode->crtc_hsync_end);
Rather bail out if something is wrong?
Using hblank end only
To view, visit change 35726. To unsubscribe, or for help writing mail filters, visit settings.