[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add required FSP UPD changes for CML

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31284 )

Change subject: soc/intel/cannonlake: Add required FSP UPD changes for CML
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/#/c/31284/9/src/soc/intel/cannonlake/fsp_params.... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/31284/9/src/soc/intel/cannonlake/fsp_params.... 
PS9, Line 38: #if IS_ENABLED(CONFIG_SOC_INTEL_COMETLAKE)
> But those UPDs could have different values for different mainboards. How would common soctree. […]

we can take 2 steps path.

1. Common UPDs across all mainboards can move to soc/soctree.cb
2. UPDs are mb specific might still exist in mb/devicetree.cb

#2 is against what Nico is trying to achieve so I'm not sure if we  can have other plan.