Felix Held submitted this change.
mb/google/guybrush: Remove the GPIO_SIGN_OF_LIFE code
Guybrush is pretty definitely alive, so this can be removed, as the
TODO line said.
BUG=180721202
TEST=Build
Signed-off-by: Martin Roth <martinroth@chromium.org>
Change-Id: I14f89f3e6f780c2da2136a838950ef2bcebc4c3a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52740
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
---
M src/mainboard/google/guybrush/Kconfig
M src/mainboard/google/guybrush/bootblock.c
2 files changed, 0 insertions(+), 19 deletions(-)
diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig
index 8f160fa..51ac55d 100644
--- a/src/mainboard/google/guybrush/Kconfig
+++ b/src/mainboard/google/guybrush/Kconfig
@@ -96,11 +96,4 @@
string
default "Google_Guybrush"
-config GPIO_SIGN_OF_LIFE
- def_bool n
- help
- Enable toggling GPIO 31 as a sign of life on Guybrush
-
- TODO: Remove this option when board is booting
-
endif # BOARD_GOOGLE_BASEBOARD_GUYBRUSH
diff --git a/src/mainboard/google/guybrush/bootblock.c b/src/mainboard/google/guybrush/bootblock.c
index ece1201..5b18d37 100644
--- a/src/mainboard/google/guybrush/bootblock.c
+++ b/src/mainboard/google/guybrush/bootblock.c
@@ -5,9 +5,6 @@
#include <baseboard/variants.h>
#include <console/console.h>
#include <device/pci_ops.h>
-#include <delay.h>
-#include <gpio.h>
-#include <soc/gpio.h>
#include <soc/pci_devs.h>
void bootblock_mainboard_early_init(void)
@@ -38,15 +35,6 @@
dword |= 3 << 10;
pm_write32(0x74, dword);
- if (CONFIG(GPIO_SIGN_OF_LIFE)) {
- for (int x = 0; x < 20; x++) {
- gpio_set(GPIO_31, 1);
- mdelay(10);
- gpio_set(GPIO_31, 0);
- mdelay(10);
- }
- }
-
if (variant_has_fpmcu())
variant_fpmcu_reset();
}
To view, visit change 52740. To unsubscribe, or for help writing mail filters, visit settings.