Patch Set 4:
I think your port is another variant compared to this one: https://review.coreboot.org/c/coreboot/+/25662
It could be added as a variant, but I would wait a bit. I want to see if merging all the Asus sandy/ivy boards would be feasible. There's only two different SuperIOs.
15 comments:
File src/mainboard/asus/p8z77-m/Kconfig:
Patch Set #4, Line 21: select INTEL_INT15
This is used with the VBIOS, but I don't think anyone should be using it
File src/mainboard/asus/p8z77-m/board_info.txt:
Patch Set #4, Line 6: Flashrom support: ?
Does `sudo flashrom -p internal --ifd -i bios -w build/coreboot.rom -N` work?
File src/mainboard/asus/p8z77-m/cmos.default:
otherwise
File src/mainboard/asus/p8z77-m/devicetree.cb:
# FIXME: check gfx.ndid and gfx.did
register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }"
register "gfx.ndid" = "3"
Just remove them. They cause ACPI errors.
0
0
0
Patch Set #4, Line 37: register "gen4_dec" = "0x00000000"
It's zero, you can remove it
Patch Set #4, Line 53: Audio Audio
It's stereo audio!
Patch Set #4, Line 64: LPC bridge PCI-LPC bridge
Some obnoxious redundancy here
Patch Set #4, Line 95: # Deep sleep
This comment is not aligned
File src/mainboard/asus/p8z77-m/dsdt.asl:
Patch Set #4, Line 17: #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0
Not needed.
File src/mainboard/asus/p8z77-m/early_init.c:
Patch Set #4, Line 88: void mainboard_fill_pei_data(struct pei_data *pei_data)
I think you need to guard these
File src/mainboard/asus/p8z77-m/gma-mainboard.ads:
Patch Set #4, Line 32: Internal
At least "Internal" is not there. Replace it with:
Others => Disabled
File src/mainboard/asus/p8z77-m/mainboard.c:
Patch Set #4, Line 10: fix those values
Or remove the entire file.
To view, visit change 38988. To unsubscribe, or for help writing mail filters, visit settings.