Discussed with DSI, the DSI IP (MediaTek MIPI DPHY) used by 8173 is obsolete.
What about rename to mtk_mipi_dphy_v2.c ?

I think the goal is to have a name that consistent with your internal naming or understanding.

Do you really call that DSI IP "v2"? If yes then we can do it, otherwise I'm fine with just calling this 'common/mtk_mipi_dphy.c' and use it (and just forget about 8173 since it's pretty old and we'll not have more SOCs sharing its code base)

View Change

To view, visit change 48530. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I722d3e67f230ab8eb729900cdf15b922eb91a072
Gerrit-Change-Number: 48530
Gerrit-PatchSet: 4
Gerrit-Owner: Yidi Lin <yidi.lin@mediatek.com>
Gerrit-Reviewer: Huijuan Xie <huijuan.xie@mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 11 Dec 2020 05:53:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment