Hello Sajida Bhanu,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/40534
to review the following change.
Change subject: trogdor: Update pull for Sd-card detect pin ......................................................................
trogdor: Update pull for Sd-card detect pin
Configuring pull for SD-card detect pin. Without this SD-card detection is not working as expected
Signed-off-by: Shaik Sajida Bhanu sbhanu@codeaurora.org Change-Id: I77bf355a049224784a160defa6bee66d0f9ceb75 --- M src/mainboard/google/trogdor/chromeos.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/40534/1
diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c index b13f88f..3d535c8 100644 --- a/src/mainboard/google/trogdor/chromeos.c +++ b/src/mainboard/google/trogdor/chromeos.c @@ -29,6 +29,7 @@ gpio_input_pullup(GPIO_AP_EC_INT); gpio_output(GPIO_AP_SUSPEND, 1); gpio_input(GPIO_WP_STATE); + gpio_input_pullup(GPIO_SD_CD_L); gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP); gpio_output(GPIO_AMP_ENABLE, 1); }