4 comments:
Patch Set #1, Line 308: static
ok, can be dropped then I guess. […]
without static you're returning a pointer to that string but the variable is local. that won't work ofc. that's why vpd_gets uses that buffer :D my fault, sry ;)
har *smbios_system_serial_number(void)
{
static char serial[VPD_SERIAL_LEN];
if (vpd_gets(VPD_KEY_SYSTEM_SERIAL, serial, VPD_SERIAL_LEN, VPD_RO))
return serial;
return "";
}
const char *smbios_mainboard_serial_number(void)
{
static char serial[VPD_SERIAL_LEN];
if (vpd_gets(VPD_KEY_MAINBOARD_SERIAL, serial, VPD_SERIAL_LEN, VPD_RO))
return serial;
return "";
}
#endif
ah, I missed that it's defined weak in smbios code, nvm then
Done
Patch Set #2, Line 301: #if CONFIG(SMBIOS_SERIAL_FROM_VPD)
Does the code need to be in this compilation unit? If not, the guard could […]
Done
File src/mainboard/google/drallion/ramstage.c:
Patch Set #3, Line 9: #include <vendorcode/google/chromeos/chromeos.h>
shouldn't be needed anymore
To view, visit change 49050. To unsubscribe, or for help writing mail filters, visit settings.