Patch Set 6:

Patch Set 6:

please have a look at https://review.coreboot.org/c/coreboot/+/44783.

it proposes to pass the audio config hint up to the kernel based on
the audio config specified in CBI.FW_CONFIG. this means we'll need
to keep FW_CONFIG enabled. when FW_CONFIG is enabled,
volteer/fw_config.c:fw_config_handle() is going to run and as
soon as someone adds a different audio config for UP4, we'll
have to handle both cases. right now, fw_config_handle() does
nothing for halvor, so the settings in gpio.c are sufficient,
but i think this will break if we have another UP4 board that
supports multiple audio configs.

perhaps one way out is allow a compile-time (kconfig?) over-ride
for the FW_CONFIG audio DB value.

Hi Caveh and Google,

We have another CL for fw_config MAX98373_ALC5682I_I2S_UP4.
https://review.coreboot.org/c/coreboot/+/44560

Could you give us advise to merge the CL?
Thank you.

Hi Google,

Is there suggestion for us to merge the CL?
Thank you.

View Change

To view, visit change 44409. To unsubscribe, or for help writing mail filters, visit settings.