Patch set 12:Code-Review +1
11 comments:
File src/soc/intel/cannonlake/pch_h.c:
Patch Set #12, Line 2: /* This file is part of the coreboot project. */
drop this comment, but leave a blank line between the SPDX identifier and the #includes
double blank line
Patch Set #12, Line 18: switch (dev->path.pci.devfn)
that open brace { should be on the previous line
agreed.
Patch Set #12, Line 20: // UART0
Such useful comments! I don't think we need them, do we? 😄
Patch Set #12, Line 22: struct acpi_irq irq
maybe declare this outside of the switch? that way, no braces are needed.
Another double blank line
spurious blank line
Patch Set #12, Line 92: switch (dev->path.pci.devfn)
that open brace { should be on the previous line
Would be good to fix
Patch Set #12, Line 94: // UART0
We can live without these comments
double empty line
Patch Set #12, Line 119: .acpi_fill_ssdt = pch_h_uart_fill_ssdt,
We can do away with one tab less
To view, visit change 40405. To unsubscribe, or for help writing mail filters, visit settings.