Jacob Garber has uploaded this change for review.

View Change

payloads/coreinfo: Free buffer before returning

This resolves CID 1373370 (RESOURCE_LEAK), which was
partially fixed in 2d1e0eb.

Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Change-Id: I0efe94b9dfb27746828055427029c01c7f407ec2
---
M payloads/coreinfo/timestamps_module.c
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/32094/1

diff --git a/payloads/coreinfo/timestamps_module.c b/payloads/coreinfo/timestamps_module.c
index 0978f31..fe2d2b5 100644
--- a/payloads/coreinfo/timestamps_module.c
+++ b/payloads/coreinfo/timestamps_module.c
@@ -203,8 +203,10 @@
 			SCREEN_X, LINES_SHOWN);
 
 	/* Sanity check, chars_count must be padded to full line */
-	if (chars_count % SCREEN_X != 0)
+	if (chars_count % SCREEN_X != 0) {
+		free(buffer);
 		return -2;
+	}
 
 	g_lines_count = chars_count / SCREEN_X;
 	g_max_cursor_line = MAX(g_lines_count - 1 - LINES_SHOWN, 0);

To view, visit change 32094. To unsubscribe, or for help writing mail filters, visit settings.