Patch Set #8, Line 27:
Patch Set #8, Line 45:
Looking at the code it seems limited to 8 bits? So why isn't it a `u8`?
Patch Set #8, Line 34:
I think this belongs before the line above it. Currently the […]
Well, what you're saying seems logical, but this code is from apple-gmux linux driver. Maybe it's just a mistake, maybe not. I will eventually test all this more deeply. But for now I can't answer to this and some other your comments
Patch Set #8, Line 32:
/* Don't confuse anyone else and disable the fake device */
Why? Who would get confused?
This is a copy-pasta from lenovo/hybrid_graphics driver, siro should know :)
But my guess is that devices might be enumarated somewhere else in the code and this fake device should be marked as disabled because this is not a real device
Patch Set #8, Line 30:
/* TODO: Use generic device instead of dummy PNP device */
The generic device couldn't be used at time of writing the lenovo hybrid graphics driver. […]
It's based on lenovo/hybrid_graphics. I can rewrite it the right way, though I don't know it, tell me please where I can see an example or something
To view, visit change 32719. To unsubscribe, or for help writing mail filters, visit settings.