Patch Set 7:

Patch Set 7:

Looks like this improves loading postcar stage with ~1ms. Thanks for testing.

Which timestamps exactly did you compare? It looked like 22ms overall increment to me.

The difference between '3:after ram initialization' and '100:start of postcar' which this change affects.

1ms improvement is just noise here in my opinion, specially when adding new dependency on having AGESA do MTRR setups.

View Change

To view, visit change 37198. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62ffe1bd646e9ddad77be240f030601790f4da4b
Gerrit-Change-Number: 37198
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Marshall Dawson <marshall.dawson@amd.corp-partner.google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Krystian Hebel <krystian.hebel@3mdeb.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Mike Banon <mikebdp2@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 28 May 2020 21:57:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment