Patch set 29:Code-Review -1
12 comments:
Patch Set #29, Line 9: combination
It can be done without breaking anything.
Patch Set #29, Line 16: resource
Why does it create a resource list?
Where is it stored?
What spec was used to write the code?
Patch Set #29, Line 16: tables
Where reside the page tables?
What mapping is used?
Identity mapping?
Why does it use paging?
File src/security/intel/stm/Kconfig:
Patch Set #29, Line 5: default
Some Intel platforms are missing, why?
Patch Set #29, Line 6: (PLATFORM_USES_FSP2_0||PLATFORM_USES_FSP1_1||PLATFORM_USES_FSP1_0)
FSP1_0 support was dropped.
Shouldn't this depend on the presence of TSEG?
File src/security/intel/stm/SmmStm.c:
Patch Set #29, Line 483: retval
Never returned
File src/security/intel/stm/StmPlatformResource.c:
Patch Set #29, Line 113: ACPI_BASE_ADDRESS
Platform specific code doesn't belong here
Patch Set #29, Line 116: attribute__((weak))
No need for weak
Depends on the mmconf size
Patch Set #29, Line 157: Fix-up
What's fixed?
File src/security/intel/stm/StmPlatformSmm.c:
Patch Set #29, Line 32: retval
No true, returns only a single retval
Patch Set #29, Line 81: mem_region_device_ro_init(&stm_region
No commented code
To view, visit change 33234. To unsubscribe, or for help writing mail filters, visit settings.