Attention is currently required from: Felix Singer, Furquan Shaikh, Ravishankar Sarawadi, Tim Wawrzynczak, Srinidhi N Kaushik, Raj Astekar.
View Change
1 comment:
Patchset:
Patch Set #4:
On the other hand, this way it is more modular. […]
I too agree with Tim. Although, my interpretation may differ. :)
We should have something selectable to decide the FSP version. Or
better to set the default in the choice (in the follow-up change).
Instead of going the indirect route via SKUs, it should just reflect
what it effectively does, e.g.
config SOC_INTEL_TIGERLAKE_CLIENT_FSP_DEFAULT
bool
config SOC_INTEL_TIGERLAKE_IOT_FSP_DEFAULT
bool
Or even just one and an implicit default for the other.
These would be additional configs, on top of the SOC_INTEL_TIGERLAKE
selection. Thus, should be part of the follow-up change, and IMHO we
can abandon this one.
(Overthinking it: To fully model reality, we would need both, the
SKU selection and the FSP version. The SKU selection would decide
which options are visible in the choice and the FSP option which
one would be the default if multiple options are visible. Adding an
SKU selection may be error-prone, though. Something more to main-
tain that doesn't have a direct effect, and thus could result in
subtle, hard to debug issues. It would be a different story if we did
it globally in coreboot. I.e. always select exactly the chip SKUs that
are expected to be soldered on a board. This would also have other
advantages like better default choices of added microcode updates.
But without training us first (hence better do it globally) it could
be too error-prone.)
To view, visit change 49055. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I575f28c7eaa82ed5d52ba7c9328a52e76d71dc5b
Gerrit-Change-Number: 49055
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone@intel.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Raj Astekar <raj.astekar@intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi@intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Furquan Shaikh <furquan@google.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi@intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik@intel.com>
Gerrit-Attention: Raj Astekar <raj.astekar@intel.com>
Gerrit-Comment-Date: Sun, 25 Apr 2021 10:09:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-MessageType: comment