Attention is currently required from: Pablo Stebler, Paul Menzel, Iru Cai (vimacs).
2 comments:
Patchset:
Sorry for the confusion, I did not mean to say "use 10s and ignore
everything Angel said". 10s was just an exaggerated example to make
a point :)
To rephrase, I think there are three sorts of timeouts.
a) when we know how to handle it,
b) when we don't know how to handle it and hardware may stall indefinitely, and
c) when we don't know how to handle it and we have never seen hardware stalling indefinitely.
If we assume c) (we can be sure for your device but for earlier ports,
we'll assume that), that assumption should be documented in the commit
message.
I don't know how long your hardware takes. If it's in the order of
magnitude of 100ms, maybe just use 1s. That should be enough to
make people look into the log what is taking so long, without causing
much pain.
Also, please mention the times you observed in the commit message
(maybe along with your EC firmware version, which probably matters
more than the hardware).
File src/ec/hp/kbc1126/ec.c:
Patch Set #9, Line 27: 0x100000
Please use decimal numbers for times.
To view, visit change 44750. To unsubscribe, or for help writing mail filters, visit settings.