Patch set 5:Code-Review +2
View Change
1 comment:
Commit Message:
Patch Set #5, Line 10:
From GPU document,BOMACO is defined "Bus Off Memory Alive Core Off".
I guess that's a power-saving mode where only the VRAM is powered. That would be the dGPU equivalent of ACPI S3 (the memory contents are preserved, but the rest of the system is powered off). Sounds pretty interesting, as it would provide good power savings at a reduced exit latency :-D
In any case, it would be nice to add this to the commit message:
BOMACO stands for "Bus Off Memory Alive Core Off".
To view, visit change 38210. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic35e55771d76b7254bcb457fcb38f37433b9ad67
Gerrit-Change-Number: 38210
Gerrit-PatchSet: 5
Gerrit-Owner: Amanda Hwang <amanda_hwang@compal.corp-partner.google.com>
Gerrit-Reviewer: Amanda Hwang <amanda_hwang@compal.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su@compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 31 Jan 2020 09:44:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Comment-In-Reply-To: John Su <john_su@compal.corp-partner.google.com>
Gerrit-MessageType: comment