Uhh... context? I rather like my macro and would prefer to keep it unless there are real issues with it that cannot be solved otherwise. Can you explain how it "broke master quite spectacularly"?

see https://qa.coreboot.org/job/coreboot-gerrit/121768/testReport/junit/(root)/board/GOOGLE_SCARLET/ for the breakage it caused

the non-functional spdx license header changes caused some line numbers to shift which resulted in the same symbol being generated twice by the macro, which made the build fail. so yes, i don't like that macro too much. Maybe add a __COUNTER__ instead of the tag added in https://review.coreboot.org/c/coreboot/+/40140 as a hotfix, that made the tree build again?

View Change

To view, visit change 40141. To unsubscribe, or for help writing mail filters, visit settings.